Make VxWorks shims unsafe#3727
Merged
Merged
Conversation
`pread` and `pwrite` don't technically need to be `unsafe`, but it is consistent and more convenient for avoiding the `unused_unsafe` warning across targets.
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
JohnTitor
approved these changes
Jun 15, 2024
This was referenced Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
preadandpwritedon't technically need to beunsafe, but it is consistent and more convenient for avoiding theunused_unsafewarning across targets.posix_memalignmust beunsafesince it writes to the ptr argmemptr.This is a breaking change.