Skip to content

netbsd: Export ioctl request generator macros#4460

Merged
tgross35 merged 1 commit into
rust-lang:mainfrom
qinghon:main
Jul 29, 2025
Merged

netbsd: Export ioctl request generator macros#4460
tgross35 merged 1 commit into
rust-lang:mainfrom
qinghon:main

Conversation

@qinghon

@qinghon qinghon commented May 24, 2025

Copy link
Copy Markdown
Contributor

Description

add ioctl request generator macros for netbsd like

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see rust-lang/libc#3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

    ci broken in netbsd

@rustbot label +stable-nominated

@rustbot

rustbot commented May 24, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in OpenBSD module

cc @semarie

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label May 25, 2025
Comment thread src/unix/bsd/netbsdlike/mod.rs Outdated
@rustbot

rustbot commented May 25, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in OpenBSD module

cc @semarie

Comment thread src/unix/bsd/netbsdlike/mod.rs Outdated
@semarie

semarie commented May 25, 2025

Copy link
Copy Markdown
Contributor

with IOC_INOUT fixed, the change is fine regarding OpenBSD.

@qinghon qinghon requested a review from semarie May 26, 2025 07:03
Comment thread libc-test/semver/openbsd.txt
Comment thread libc-test/semver/netbsd.txt
Comment thread src/unix/bsd/netbsdlike/mod.rs
@qinghon qinghon requested a review from semarie May 26, 2025 14:47

@semarie semarie left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tgross35 I reviewed both OpenBSD and NetBSD code, and it looks fine.
But I only tested it on OpenBSD.

@tgross35 tgross35 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry this took so long for me to get to, LGTM as well

@tgross35 tgross35 enabled auto-merge July 28, 2025 08:30
auto-merge was automatically disabled July 28, 2025 15:44

Head branch was pushed to by a user without write access

@qinghon

qinghon commented Jul 28, 2025

Copy link
Copy Markdown
Contributor Author

@tgross35
The PR has been open too long and the code style has drifted. I've fixed it, but now it requires a manual merge.

@tgross35

Copy link
Copy Markdown
Contributor

I didn't realize how much back and forth this history had; there shouldn't "fix bug" commits if they fix bugs introduced in this PR. Please squash, and rebase to drop the merge commit.

@qinghon

qinghon commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

@tgross35 thanks for you review

@tgross35 tgross35 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@tgross35 tgross35 added this pull request to the merge queue Jul 29, 2025
Merged via the queue into rust-lang:main with commit e7cf1cc Jul 29, 2025
48 of 52 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jul 29, 2025
@tgross35 tgross35 mentioned this pull request Jul 29, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 11, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 11, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Aug 11, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Aug 11, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-unix stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants