Fix the sign of the EVFILT_* defines#506
Closed
TethysSvensson wants to merge 1 commit intorust-lang:masterfrom
TethysSvensson:netbsd-evfilt-sign
Closed
Fix the sign of the EVFILT_* defines#506TethysSvensson wants to merge 1 commit intorust-lang:masterfrom TethysSvensson:netbsd-evfilt-sign
TethysSvensson wants to merge 1 commit intorust-lang:masterfrom
TethysSvensson:netbsd-evfilt-sign
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
Note that this only affects netbsd. |
Member
|
Looks good to me, but unfortunately like #503 we'll probably have to wait until the next major version :( |
Susurrus
pushed a commit
to Susurrus/libc
that referenced
this pull request
Mar 26, 2017
Susurrus
pushed a commit
to Susurrus/libc
that referenced
this pull request
Mar 26, 2017
Improve AIO API - Turn most `aio_*` functions into `AioCb` methods - Add runtime checks to `AioCb` methods - Implement `Drop` for `AioCb`
Contributor
|
@TethysSvensson I think this can be merged without issues. Could you rebase this on top of master ? |
Contributor
Author
|
This was already fixed independently in a0e683e. |
Contributor
Author
|
As far as I can tell, this was the only change included in #787 -- so I guess no breakage was found? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sign of the defines are not actually consistent with where they are used.
They are used in the
keventstruct, which defines thefilterfield asuint32_t. This is also consistent with the netbsd header files, where the field is auint32_tand the constants are defined as e.g.: