Place::Local(x) is now Place::Base(PlaceBase::Local(x))#647
Merged
RalfJung merged 2 commits intorust-lang:masterfrom Mar 2, 2019
Merged
Place::Local(x) is now Place::Base(PlaceBase::Local(x))#647RalfJung merged 2 commits intorust-lang:masterfrom
RalfJung merged 2 commits intorust-lang:masterfrom
Conversation
Member
|
We cannot land this before the rustc PR merges, but you can just break Miri after the beta train left. |
Member
Author
|
@RalfJung and how do we land the PR on rustc with the CI failing because this PR is not in 😄 |
Member
|
Yeah cyclic dependencies are fun. ;) After Thursday, your PR can land on rustc even if it breaks Miri. The "though shall not break a tool" is only in effect the week before the beta train leaves. |
Member
Author
|
@RalfJung good to know :) |
Member
Author
Contributor
|
Hm. looks like we need to wait for a nightly. |
RalfJung
added
S-waiting-on-nightly
and removed
S-blocked-on-rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to merge this after the beta cut for this rust-lang/rust#58631 to work.
/cc @oli-obk