Add OsString from/to bytes helper functions by pvdrz · Pull Request #993 · rust-lang/miri

pvdrz · 2019-10-13T21:19:20Z

Related issue: #989

r? @RalfJung

src/helpers.rs

bors · 2019-10-18T08:50:16Z

☔ The latest upstream changes (presumably #1004) made this pull request unmergeable. Please resolve the merge conflicts.

src/helpers.rs

bors · 2019-10-18T14:32:15Z

☔ The latest upstream changes (presumably #1005) made this pull request unmergeable. Please resolve the merge conflicts.

RalfJung · 2019-10-19T10:05:51Z

@christianpoveda please don't delete comments, rather mark then as resolved when you resolved them. I got a notification about getcwd breakage and that seems like useful information to keep in the history, even if you managed to fix it later.

src/helpers.rs

pvdrz · 2019-10-19T19:17:03Z

@christianpoveda please don't delete comments, rather mark then as resolved when you resolved them. I got a notification about getcwd breakage and that seems like useful information to keep in the history, even if you managed to fix it later.

Just for the future us (and other minds doomed to suffer the same fate as us :P): The problem was that I was trying to write using Allocation:write_bytes and it was failing to write all the bytes causing an invalid memory access in other places. I changed to Allocation::get_bytes_mut and everything is working nice and dandy now.

Edit: This was my fault all the time... see: #993 (comment)

bors · 2019-10-21T09:43:13Z

☔ The latest upstream changes (presumably #991) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2019-10-22T11:41:25Z

☔ The latest upstream changes (presumably #1014) made this pull request unmergeable. Please resolve the merge conflicts.

RalfJung · 2019-10-22T16:41:23Z

Just add a FIXME for now.

pvdrz · 2019-10-22T16:44:58Z

Ok then we are good to go

src/shims/env.rs

src/helpers.rs

RalfJung · 2019-10-23T16:52:48Z

Thanks for the endurance, this is great. :)

@bors r+

bors · 2019-10-23T16:52:49Z

📌 Commit de12cbc has been approved by RalfJung

bors · 2019-10-23T16:52:56Z

⌛ Testing commit de12cbc with merge a05f2aa...

@RalfJung

Add OsString from/to bytes helper functions Related issue: #989 r? @RalfJung

pvdrz · 2019-10-23T16:54:45Z

OK now I can start with the other stuff :)

bors · 2019-10-23T17:21:03Z

☀️ Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing a05f2aa to master...

This was referenced Oct 13, 2019

Add shims for file handling #962

Merged

Add getcwd shim #958

Merged

Add chdir shim #960

Merged

pvdrz closed this Oct 14, 2019

pvdrz reopened this Oct 14, 2019

RalfJung reviewed Oct 16, 2019

View reviewed changes

src/helpers.rs Outdated Show resolved Hide resolved

pvdrz force-pushed the os_string_helper branch from 8ddebb0 to 0f85865 Compare October 17, 2019 15:26

RalfJung reviewed Oct 17, 2019

View reviewed changes

src/helpers.rs Outdated Show resolved Hide resolved

RalfJung reviewed Oct 17, 2019

View reviewed changes

src/helpers.rs Outdated Show resolved Hide resolved

RalfJung reviewed Oct 17, 2019

View reviewed changes

src/helpers.rs Outdated Show resolved Hide resolved

RalfJung reviewed Oct 17, 2019

View reviewed changes

src/helpers.rs Outdated Show resolved Hide resolved

RalfJung reviewed Oct 18, 2019

View reviewed changes

src/helpers.rs Outdated Show resolved Hide resolved

pvdrz force-pushed the os_string_helper branch from 280fb42 to 7218df8 Compare October 18, 2019 14:20

pvdrz added 4 commits October 18, 2019 09:47

Add OsString from/to bytes helper functions

61da8b8

Change helper functions to read/write

1241abb

Use conditional compilation properly and work with OsStrs instead

68fec4b

Rename write/read os string functions

85941c7

pvdrz force-pushed the os_string_helper branch from 197360c to 85941c7 Compare October 18, 2019 14:50

Fix writing errors

0201cc5

RalfJung reviewed Oct 19, 2019

View reviewed changes

src/helpers.rs Show resolved Hide resolved

RalfJung reviewed Oct 19, 2019

View reviewed changes

src/helpers.rs Outdated Show resolved Hide resolved

RalfJung reviewed Oct 19, 2019

View reviewed changes

src/helpers.rs Outdated Show resolved Hide resolved

RalfJung reviewed Oct 19, 2019

View reviewed changes

src/helpers.rs Outdated Show resolved Hide resolved

RalfJung reviewed Oct 19, 2019

View reviewed changes

src/helpers.rs Outdated Show resolved Hide resolved

Change comparison order for clarity

ab05967

Do additional bounds checks

f7c6e0e

Add docs for the new helper functions

283a130

RalfJung mentioned this pull request Oct 21, 2019

Some direct memory accesses lack bounds-checks #1007

Closed

3 tasks

Fix merge conflicts

72bd25d

pvdrz force-pushed the os_string_helper branch from ed2d0e6 to 129b11d Compare October 22, 2019 16:22

Use new write_bytes method

be415db

pvdrz force-pushed the os_string_helper branch from 129b11d to be415db Compare October 22, 2019 16:44

RalfJung reviewed Oct 22, 2019

View reviewed changes

src/shims/env.rs Outdated Show resolved Hide resolved

RalfJung reviewed Oct 22, 2019

View reviewed changes

src/helpers.rs Outdated Show resolved Hide resolved

Make size error distinguishable from other errors

fb4cb5b

RalfJung reviewed Oct 23, 2019

View reviewed changes

src/helpers.rs Outdated Show resolved Hide resolved

Fix documentation

de12cbc

pvdrz requested a review from RalfJung October 23, 2019 13:58

bors added a commit that referenced this pull request Oct 23, 2019

Auto merge of #993 - christianpoveda:os_string_helper, r=RalfJung

a05f2aa

Add OsString from/to bytes helper functions Related issue: #989 r? @RalfJung

bors merged commit de12cbc into rust-lang:master Oct 23, 2019

RalfJung mentioned this pull request Oct 24, 2019

OsString helpers #989

Closed

Conversation

pvdrz commented Oct 13, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bors commented Oct 18, 2019

Uh oh!

Uh oh!

bors commented Oct 18, 2019

Uh oh!

RalfJung commented Oct 19, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pvdrz commented Oct 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Oct 21, 2019

Uh oh!

bors commented Oct 22, 2019

Uh oh!

RalfJung commented Oct 22, 2019 via email

Uh oh!

pvdrz commented Oct 22, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RalfJung commented Oct 23, 2019

Uh oh!

bors commented Oct 23, 2019

Uh oh!

bors commented Oct 23, 2019

Uh oh!

pvdrz commented Oct 23, 2019

Uh oh!

bors commented Oct 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pvdrz commented Oct 19, 2019 •

edited

Loading