Skip to content

extern types #1861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aturon merged 19 commits into from
Jul 25, 2017
Merged

extern types #1861

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
6085dc4
Add extern types RFC
canndrew Jan 21, 2017
b2d8042
One sentance per line so future diffs are readable. 2 and typo fixes too
Ericson2314 Jan 21, 2017
e6f7f93
Expand teaching section
Ericson2314 Jan 21, 2017
083adad
Shout-out to roadmap with it's focus on FFI in the motivation section
Ericson2314 Jan 21, 2017
2f77316
Add ```rust in a few more places to get syntax highlighting
Ericson2314 Jan 21, 2017
949c292
Mention `size_of_val`/`align_of_val` in detailed design
Ericson2314 Jan 21, 2017
9f6d098
OOps
Ericson2314 Jan 21, 2017
cf183e9
"Sized" is the trait, not "?Sized"
Ericson2314 Jan 21, 2017
434b472
Talk about `c_void`, and associated representation concerns
Ericson2314 Jan 21, 2017
b3d5ba3
Merge pull request #1 from Ericson2314/extern-types
canndrew Jan 21, 2017
bce8a7b
Grammatic changes
canndrew Jan 21, 2017
156ed4b
Remove indentation and invalid syntax
canndrew Jan 21, 2017
caa048b
Fix typo
canndrew Jan 23, 2017
d76b608
Mention OpaqueData as an alternative
canndrew Jan 27, 2017
a590767
grammar/typos
canndrew Apr 30, 2017
9efddd3
Update with feedback
canndrew Apr 30, 2017
263b7c9
Clarify that extern type pointers are thin pointers
canndrew Jul 24, 2017
e884a0b
re-word last commit
canndrew Jul 25, 2017
4b971bd
RFC 1861 is Extern types
aturon Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
"Sized" is the trait, not "?Sized"
  • Loading branch information
@Ericson2314
Ericson2314 committed Jan 21, 2017
commit cf183e93cacb2d9649d4476504370a7905c26c29
2 changes: 1 addition & 1 deletion text/0000-extern-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ These can also be declared inside an `extern` block:
}
```

These types are FFI-safe. They are also DSTs, meaning that they implement `?Sized`. Being DSTs, they cannot be kept on the stack and can only be accessed through pointers.
These types are FFI-safe. They are also DSTs, meaning that they do not implement `Sized`. Being DSTs, they cannot be kept on the stack and can only be accessed through pointers.

In Rust, pointers to DSTs carry metadata about the object being pointed to.
For strings and slices this is the length of the buffer, for trait objects this is the object's vtable.
Expand Down