Closed
Conversation
Contributor
|
I'm not in favour of this. Unsafe code is already hard to get right, let alone adding new sources of non-explicitness which can't easily be checked at the source level. |
Contributor
There was a problem hiding this comment.
This seems like the more fundamental problem, and the one that would fix your issue: Rust doesn't offer flexible enough control over statics to be able to use safe(r) wrappers for this use case.
(That said, it is just essentially just 8 bytes in rodata, right?)
Author
There was a problem hiding this comment.
It's 4 bytes in rodata, four more instructions to fetch the address from there at each call invocation. That isn't critically significant, but easily adds useless weight to binary.
Author
|
Deprecating this in favour of #44 |
withoutboats
pushed a commit
to withoutboats/rfcs
that referenced
this pull request
Jan 15, 2017
Fixed a typo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.