Skip to content

Turn let-else statements into let and match#12130

Merged
bors merged 5 commits into
rust-lang:masterfrom
weirane:let-else-let-match
May 17, 2022
Merged

Turn let-else statements into let and match#12130
bors merged 5 commits into
rust-lang:masterfrom
weirane:let-else-let-match

Conversation

@weirane

@weirane weirane commented May 1, 2022

Copy link
Copy Markdown
Contributor

Fixes #11906.

@bors

bors commented May 1, 2022

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #12118) made this pull request unmergeable. Please resolve the merge conflicts.

@weirane weirane force-pushed the let-else-let-match branch from 60fed92 to 59cdb31 Compare May 1, 2022 16:46
Comment thread crates/ide-assists/src/handlers/convert_let_else_to_match.rs
Comment thread crates/ide-assists/Cargo.toml Outdated
@weirane weirane force-pushed the let-else-let-match branch from f875d05 to a70beea Compare May 2, 2022 22:20
Comment thread crates/ide-assists/src/handlers/convert_let_else_to_match.rs
Comment thread crates/ide-assists/src/handlers/convert_let_else_to_match.rs Outdated
Comment thread crates/ide-assists/src/handlers/convert_let_else_to_match.rs Outdated
@weirane weirane force-pushed the let-else-let-match branch from 4059fa1 to 8d7a393 Compare May 5, 2022 18:44
Comment thread crates/ide-assists/src/handlers/convert_let_else_to_match.rs Outdated

@Veykril Veykril left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for taking this long to get back to this. Looks good to me with one small nit left. Thanks!

@bors delegate+

@Veykril

Veykril commented May 17, 2022

Copy link
Copy Markdown
Member

@bors delegate+

@bors

bors commented May 17, 2022

Copy link
Copy Markdown
Contributor

✌️ @weirane can now approve this pull request

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
@weirane weirane force-pushed the let-else-let-match branch from 0d3d520 to 4a0821f Compare May 17, 2022 18:45
@weirane

weirane commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

@bors r+

@bors

bors commented May 17, 2022

Copy link
Copy Markdown
Contributor

📌 Commit 4a0821f has been approved by weirane

@bors

bors commented May 17, 2022

Copy link
Copy Markdown
Contributor

⌛ Testing commit 4a0821f with merge 187bd7d...

@weirane

weirane commented May 17, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the suggestions!

@bors

bors commented May 17, 2022

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: weirane
Pushing 187bd7d to master...

@bors bors merged commit 187bd7d into rust-lang:master May 17, 2022
@weirane weirane deleted the let-else-let-match branch May 17, 2022 19:12
@lnicola

lnicola commented May 23, 2022

Copy link
Copy Markdown
Member
let-else.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Add assist to turn let-else statements into let statements + match expression

5 participants