fix: Fix a crash introduced in #13147#13257
Merged
Merged
Conversation
Member
Author
|
@bors r+ |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
Sep 19, 2022
…hods, r=lnicola Revert "fix: handle trait methods as inherent methods for trait-related types" Reverts #13147 https://github.com/rust-lang/rust-analyzer/actions/runs/3041499441/jobs/4898678721#step:18:62
Member
Author
|
@bors r- |
Contributor
|
☀️ Try build successful - checks-actions |
lnicola
force-pushed
the
revert-13147-fix/dyn-ty-inherent-methods
branch
from
878a403 to
e54f61d
Compare
lnicola
changed the title
Member
Author
|
@bors r+ |
Contributor
Contributor
Member
Author
|
CC @lowr |
Contributor
|
☀️ Test successful - checks-actions |
bors
added a commit
that referenced
this pull request
Sep 19, 2022
Ensure at least one trait bound in `TyKind::DynTy` One would expect `TyKind::DynTy` to have at least one trait bound, but we may produce a dyn type with no trait bounds at all. This patch prevents it by returning `TyKind::Error` in such cases. An "empty" dyn type would have caused panic during method resolution without #13257. Although already fixed, I think an invariant to never produce such types would help prevent similar problems in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #13147
https://github.com/rust-lang/rust-analyzer/actions/runs/3041499441/jobs/4898678721#step:18:62