Don't run proc-macro-srv tests on the rust-analyzer repo#13286
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 23, 2022
Merged
Don't run proc-macro-srv tests on the rust-analyzer repo#13286bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Veykril
force-pushed
the
proc-macro-srv-tests
branch
from
b4167b8 to
a1aad7c
Compare
proc-macro ABI breakage still affects the tests when a new stable version releases. Ideally we'd still be able to run the tests on the rust-analyzer repo without having to update the proc-macro ABI, but for now just to unblock CI we will ignore them here, as they are still run in upstream.
Veykril
force-pushed
the
proc-macro-srv-tests
branch
from
a1aad7c to
f57cd83
Compare
Member
Author
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-actions |
Member
|
This didn't end up working very well: https://github.com/rust-lang/rust/actions/runs/3133906332/jobs/5087804712#step:25:1191. |
Member
Author
|
Hm, guess we'll have to swap in an |
Member
|
You can also use |
bors
added a commit
that referenced
this pull request
Sep 27, 2022
Use cfg(any()) instead of cfg(FALSE) for disabling proc-macro test cc #13286
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proc-macro ABI breakage still affects the tests when a new stable version releases. Ideally we'd still be able to run the tests on the rust-analyzer repo without having to update the proc-macro ABI, but for now just to unblock CI we will ignore them here, as they are still run in upstream.