Skip to content

minor: sync from downstream#13924

Merged
bors merged 4 commits into
rust-lang:masterfrom
lnicola:sync-from-rust
Jan 10, 2023
Merged

minor: sync from downstream#13924
bors merged 4 commits into
rust-lang:masterfrom
lnicola:sync-from-rust

Conversation

@lnicola

@lnicola lnicola commented Jan 10, 2023

Copy link
Copy Markdown
Member

No description provided.

RalfJung and others added 3 commits November 25, 2022 08:52
and fix the same typo in a bunch of other places
RefCell::get_mut: fix typo

and fix the same typo in a bunch of other places
Merge commit '368e0bb32f1178cf162c2ce5f7e10b7ae211eb26'
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2023
@lnicola

lnicola commented Jan 10, 2023

Copy link
Copy Markdown
Member Author

r? @arcnmx

@lnicola

lnicola commented Jan 10, 2023

Copy link
Copy Markdown
Member Author

Umm, these changes don't look right, where did they come from?

@lnicola

lnicola commented Jan 10, 2023

Copy link
Copy Markdown
Member Author

I think I'm running into the same issue as in #13459, so I must be doing something really wrong :(.

@lnicola

lnicola commented Jan 10, 2023

Copy link
Copy Markdown
Member Author

Okay, I think it's fine now?

@lnicola

lnicola commented Jan 10, 2023

Copy link
Copy Markdown
Member Author

r? @Veykril

Want to merge this so we unblock the other PRs?

@Veykril

Veykril commented Jan 10, 2023

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

📌 Commit 13aa7a2 has been approved by Veykril

It is now in the queue for this repository.

@bors

bors commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

⌛ Testing commit 13aa7a2 with merge 8eb7522...

@lnicola lnicola changed the title internal: sync from downstream minor: sync from downstream Jan 10, 2023
@bors

bors commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 8eb7522 to master...

@bors bors merged commit 8eb7522 into rust-lang:master Jan 10, 2023
@lnicola lnicola deleted the sync-from-rust branch January 10, 2023 17:05
@fasterthanlime

Copy link
Copy Markdown
Contributor

Okay, I think it's fine now?

Seeing this just now, do you remember what you did that went wrong and what you did to make it right? I see a "merge master into sync-from-rust" between the two comments but not sure what the timeline is exactly.

@lnicola

lnicola commented Feb 11, 2023

Copy link
Copy Markdown
Member Author

Not very well, but I think it was something really mundane like starting from a stale master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants