internal: Stop eagerly resolving inlay hint text edits for VSCode

[SomeoneToIgnore]

Send less json over the wire.
After microsoft/vscode#193124 was fixed, this change is not needed anymore.

VSCode 1.86.0 now supports double click for unresolved hint data too.

[lnicola]

You might need to rebase to fix the CI.

@davidbarsky what VS Code are you on?

[davidbarsky]

You might need to rebase to fix the CI.

@davidbarsky what VS Code are you on?

1.78 right now, but 1.82 in a week or so. We can carry this as a patch, need be.

[Veykril]

Fwiw there is version field in the InitializeParams that a client can populate. Haven't checked but I'd expect that VSCode populates that. We could read that out and make this conditional on that for a few months. Otherwise if we merge this we should bump the VSCode requirement of the client extension so that we force people to upgrade their VSCode to contain the fix.

[SomeoneToIgnore]

I'm not in a rush and can hold this PR, as the whole point of it was to get rid of any code-specific checks.

But if you want to have it nonetheless, let me know and I will push more checks on top.

[Veykril]

Rebased (because of clippy issues that were fixed on master) and made the check conditional on the vscode version s owe can just merge it now.

[Veykril]

Thanks!
@bors r+

[bors]

📌 Commit 0dbaccd has been approved by Veykril

It is now in the queue for this repository.

[bors]

⌛ Testing commit 0dbaccd with merge a0dd822...

[bors]

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing a0dd822 to master...

[Wilfred]

Looking at the upstream VS Code commit microsoft/vscode@8adf59f, I think the fix shipped in VS Code 1.86 FWIW.

[Veykril]

1.86 is what the code in the PR checks for