Remove lock on stdout

[SilasMarvin]

I've been using the lsp-server crate to develop a language server. In my crate I've been using bindgen to link with the llama.cpp and was getting undefined behavior on functions called from llama.cpp when first calling Connection::stdio(). For reasons I don't understand, the lock on stdout seems to be causing llama.cpp functions to freeze with no returned errors. My code is public and available here, but I can highlight or expand on specifics if that is helpful.

Removing the lock on stdout does fix the problem. I'm not sure if this is the right way to solve it, but was hoping to understand a little bit more why we are locking stdout.

Thank you! I love and really appreciate the work you all put into the Rust ecosystem.

[Veykril]

That sounds very odd, and certainly like a problem with llama.cpp. Us taking the lock there is intentional as no one else should be writing to stdout at that point anyways as this would interfere with the protocol.

[lnicola]

A backtrace for each thread would be useful here.

[SilasMarvin]

Thanks for the quick responses. I'll update with some more data when I get some more time to dig into it

[bors]

☔ The latest upstream changes (presumably #16704) made this pull request unmergeable. Please resolve the merge conflicts.

[Veykril]

I'll close this for now as I don't think that the issue lies on our side with this. Do come back to us if your testing says otherwise though!