Skip to content

feat: Support the ${concat(...)} metavariable expression#18151

Merged
bors merged 1 commit into
rust-lang:masterfrom
ChayimFriedman2:metavar-concat
Sep 20, 2024
Merged

feat: Support the ${concat(...)} metavariable expression#18151
bors merged 1 commit into
rust-lang:masterfrom
ChayimFriedman2:metavar-concat

Conversation

@ChayimFriedman2

Copy link
Copy Markdown
Contributor

I didn't follow rustc precisely, because I think it does some things wrongly (or they are FIXME), but I only allowed more code, not less. So we're all fine.

Closes #18145.

I didn't follow rustc precisely, because I think it does some things wrongly (or they are FIXME), but I only allowed more code, not less. So we're all fine.
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2024
@Veykril

Veykril commented Sep 20, 2024

Copy link
Copy Markdown
Member

Thanks!
@bors r+

@bors

bors commented Sep 20, 2024

Copy link
Copy Markdown
Contributor

📌 Commit 8a50aec has been approved by Veykril

It is now in the queue for this repository.

@bors

bors commented Sep 20, 2024

Copy link
Copy Markdown
Contributor

⌛ Testing commit 8a50aec with merge d4689f1...

@bors

bors commented Sep 20, 2024

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing d4689f1 to master...

@bors bors merged commit d4689f1 into rust-lang:master Sep 20, 2024
@ChayimFriedman2 ChayimFriedman2 deleted the metavar-concat branch October 6, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for macro_metavar_expr_concat

4 participants