internal: Migrate MIR to next solver#20814
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
flodiebold
approved these changes
Oct 10, 2025
|
|
||
| extern crate ra_ap_rustc_next_trait_solver as rustc_next_trait_solver; | ||
|
|
||
| extern crate self as hir_ty; |
Contributor
Author
There was a problem hiding this comment.
The new macros crate, which I decided to introduce because the boilerplate was too much for my taste.
| #[derive(Debug, Copy, Clone, Eq, PartialEq, Hash, TypeFoldable, TypeVisitable)] | ||
| pub struct ValueConst<'db> { | ||
| pub(crate) ty: Ty<'db>, | ||
| // FIXME: Should we ignore this for TypeVisitable, TypeFoldable? |
Member
There was a problem hiding this comment.
looks like rustc's ValTree simply has trivial impls?
Contributor
Author
There was a problem hiding this comment.
I'm not sure we should copy what it does, our consteval is quite different.
Contributor
Author
|
The CI failure is due to the new implementation of |
ChayimFriedman2
force-pushed
the
mir-ns
branch
from
fc8b1c0 to
1321db2
Compare
ChayimFriedman2
force-pushed
the
mir-ns
branch
from
1321db2 to
e6857aa
Compare
ShoyuVanilla
approved these changes
Oct 11, 2025
rustbot
removed
the
S-waiting-on-review
Member
|
changelog fixup #20329 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.