Migrate variance to the next solver and remove lint allows from its stuff#20867
Merged
ShoyuVanilla merged 2 commits intoOct 20, 2025
Merged
Conversation
rustbot
added
the
S-waiting-on-review
ShoyuVanilla
approved these changes
Oct 20, 2025
ShoyuVanilla
left a comment
ShoyuVanilla
left a comment
Member
There was a problem hiding this comment.
Looks good to me, though I just realized how many unused params - mostly unimplemented/unnecessary trait impls from rustc_type_ir, which are fine - we have 😅
rustbot
removed
the
S-waiting-on-review
Member
|
changelog fixup #20329 |
mendelsshop
pushed a commit
to mendelsshop/rust-analyzer
that referenced
this pull request
Oct 27, 2025
…final Migrate variance to the next solver and remove lint allows from its stuff
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewing commit-by-commit is recommended. The second commit could use a more quick review, it was mostly following the compiler.