Rip Chalk out of the codebase 🎉#20873
Conversation
| Certain(chalk_ir::Canonical<chalk_ir::ConstrainedSubst<Interner>>), | ||
| Uncertain(chalk_ir::Canonical<chalk_ir::Substitution<Interner>>), | ||
| Certain, | ||
| Uncertain, |
There was a problem hiding this comment.
Oh, we happened to be not using these(variants' fields) anymore
ShoyuVanilla
left a comment
There was a problem hiding this comment.
Looks good to me. Awesome works 🎉
BTW, could you fix this error in our metric CI in the previous PR? (I have no idea why it didn't fail beforehand in build or clippy step 🤔)
https://github.com/rust-lang/rust-analyzer/actions/runs/18644210303/job/53148291312
error: eliding a lifetime that's named elsewhere is confusing
--> crates/hir-ty/src/db.rs:316:82
|
28 | #[query_group::query_group]
| --------------------------- the lifetime is named here
...
316 | fn variances_of(&self, def: GenericDefId) -> crate::next_solver::VariancesOf<'_>;
| ^^ the same lifetime is elided here
|
= help: the same lifetime is referred to in inconsistent ways, making the signature confusing
= note: `-D mismatched-lifetime-syntaxes` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(mismatched_lifetime_syntaxes)]`
help: consistently use `'db`
|
316 - fn variances_of(&self, def: GenericDefId) -> crate::next_solver::VariancesOf<'_>;
316 + fn variances_of(&self, def: GenericDefId) -> crate::next_solver::VariancesOf<'db>;
|
Maybe we run a different Rust version in them? |
|
That sounds plausible |
|
Awesome work |
|
And yes thats a fairly new lint so not surprising we are hitting this now |
|
I'm merging this and will take care of the metrics later. |
|
I feel bad about it, but I'll relegate this to a changelog fixup #20329 |
Rip Chalk out of the codebase 🎉
The diff is huge, but it was mostly following the compiler in a cycle: removing more and more unused stuff.