Remove hir-ty/src/next_solver/mapping.rs#20896
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
requested changes
Oct 24, 2025
| #[derive(PartialOrd, Ord)] | ||
| pub struct InternedOpaqueTyId { | ||
| pub loc: ImplTraitId, | ||
| pub loc: ImplTraitId<'db>, |
Contributor
There was a problem hiding this comment.
Oh we can use 'db here?!
I would prefer not to rely on this, as this seems to be an accidental feature. Instead, remove no_lifetime and introduce a lifetime to this struct.
Contributor
Author
There was a problem hiding this comment.
I didn't expect it to work, but rustc said "use <'db> here" so i did and it worked.
Contributor
Author
There was a problem hiding this comment.
salsa::interned doesn't seem to like me adding lifetimes:
Contributor
There was a problem hiding this comment.
Let's merge this then, as it's an improvement over the status quo.
Contributor
Author
There was a problem hiding this comment.
Also adding a lifetime to InternedOpaqueTyId propagates up to SolverDefId, and farther.
rustbot
removed
the
S-waiting-on-review
Member
|
changelog fixup #20329 |
mendelsshop
pushed a commit
to mendelsshop/rust-analyzer
that referenced
this pull request
Oct 27, 2025
Remove hir-ty/src/next_solver/mapping.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's no longer needed, now that chalk is gone.