fix:Fix MIR const evaluator panic due to incompatible integer operands. - #23046
Open
YUZHEthefool wants to merge 1 commit into
Open
fix:Fix MIR const evaluator panic due to incompatible integer operands.#23046YUZHEthefool wants to merge 1 commit into
YUZHEthefool wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
|
This is not the way. MIR eval is not at fault here. MIR lowering should fail on that code, and in fact any code that has a type checking error, but that is not implemented currently and perhaps will not suffice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
错误代码让常量求值器收到了两种不兼容的整数表示。原实现默认它们一定相同，因此直接 panic；现在会先检查，不兼容时返回普通错误，避免 rust-analyzer 崩溃。
<The error code caused the constant evaluator to receive two incompatible representations of integers. The original implementation defaults that they must be the same, so it panics directly.
So now it will be checked first and return a normal error if it is incompatible to avoid rust-analyzer crashing.>
Fixed #22954