Skip to content

Derive PartialOrd when possible#1002

Merged
bors-servo merged 5 commits into
rust-lang:masterfrom
pepyakin:derive-partialord-when-possible
Sep 19, 2017
Merged

Derive PartialOrd when possible#1002
bors-servo merged 5 commits into
rust-lang:masterfrom
pepyakin:derive-partialord-when-possible

Conversation

@pepyakin

Copy link
Copy Markdown
Contributor

Fixes #882

r? @fitzgen

@fitzgen

fitzgen commented Sep 19, 2017

Copy link
Copy Markdown
Member

This looks good!

We just need some test coverage to land this. Let's add --with-derive-partialord to the // bindgen-flags line for these tests:

  • tests/headers/derive-hash-template-inst-float.hpp
  • tests/headers/derive-hash-template-def-float.hpp
  • tests/headers/derive-hash-struct-with-pointer.h
  • tests/headers/derive-hash-struct-with-float-array.h
  • tests/headers/derive-hash-struct-with-anon-struct-float.h
  • tests/headers/derive-hash-blacklisting.hpp

And then verify that the generated bindings do or don't derive(PartialOrd) as we expect them to.

Thanks!

@fitzgen

fitzgen commented Sep 19, 2017

Copy link
Copy Markdown
Member

@pepyakin, BTW, I'm not sure if you're aware that the "impl period" has just begun, but the folks hacking on bindgen during the impl period are hanging out in https://gitter.im/rust-impl-period/WG-dev-tools-bindgen if you want to join us :)

@fitzgen

fitzgen commented Sep 19, 2017

Copy link
Copy Markdown
Member

@bors-servo r+

Thanks @pepyakin !

@bors-servo

Copy link
Copy Markdown

📌 Commit e4a4b47 has been approved by fitzgen

@bors-servo

Copy link
Copy Markdown

⌛ Testing commit e4a4b47 with merge 1906a26...

bors-servo pushed a commit that referenced this pull request Sep 19, 2017
…zgen

Derive PartialOrd when possible

Fixes #882

r? @fitzgen
@bors-servo

Copy link
Copy Markdown

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 1906a26 to master...

1 similar comment
@bors-servo

Copy link
Copy Markdown

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 1906a26 to master...

@bors-servo bors-servo merged commit e4a4b47 into rust-lang:master Sep 19, 2017
@pepyakin pepyakin deleted the derive-partialord-when-possible branch September 19, 2017 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants