Unbreak shell completion and --version without header#3040
Merged
pvdrz merged 2 commits intorust-lang:mainfrom Dec 8, 2024
Merged
Unbreak shell completion and --version without header#3040pvdrz merged 2 commits intorust-lang:mainfrom
pvdrz merged 2 commits intorust-lang:mainfrom
Conversation
This regressed again in rust-lang#2984. Partially revert d75fe27 and 42a86e2 and restore the previous behavior. Fixes: rust-lang#3037 Fixes: rust-lang#3039
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Dec 7, 2024
this is rust-lang/rust-bindgen#3040 this also unbreaks the mesa-asahi build
2 tasks
pvdrz
approved these changes
Dec 8, 2024
Contributor
pvdrz
left a comment
pvdrz
left a comment
There was a problem hiding this comment.
Thanks! I added an extra commit with some regression tests so this doesn't happen again 👏
pvdrz
force-pushed
the
unbreak-version
branch
from
bcc54f7 to
9a8502f
Compare
45 tasks
bell-sw
pushed a commit
to bell-sw/alpaquita-aports
that referenced
this pull request
Dec 9, 2024
[ commit ff261ebc9ab2b7c8ccb56f341e82697f16c3699b ] this is rust-lang/rust-bindgen#3040 this also unbreaks the mesa-asahi build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This regressed again in #2984. Partially revert d75fe27 and 42a86e2 and restore the previous behavior.
Fixes: #3037
Fixes: #3039