Fix iOS mangling#776
Merged
bors-servo merged 1 commit intorust-lang:masterfrom Jun 23, 2017
snipsco:fix/ios-mangling
Merged
Conversation
Contributor
|
@bors-servo r+ Thanks a lot, and sorry for the hassle! |
|
📌 Commit 8885365 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jun 23, 2017
Fix iOS mangling Hi, We had a regression on a project that target iOS while upgrading bindgen from `0.25.3` to `0.25.4`. After a long investigation it appeared that iOS need also a mangling hack. I managed to make a patch and successfully test it. Thanks a lot for all your work. Cheers
|
☀️ Test successful - status-travis |
2 tasks
Contributor
|
I have a feeling that checking Probably something like |
Author
|
Or we could also check for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
We had a regression on a project that target iOS while upgrading bindgen from
0.25.3to0.25.4.After a long investigation it appeared that iOS need also a mangling hack. I managed to make a patch and successfully test it.
Thanks a lot for all your work.
Cheers