add [permissions_set_readonly_false] #9702#10063
Merged
Merged
Conversation
Collaborator
|
r? @Alexendoo (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Alexendoo
reviewed
Dec 11, 2022
Alexendoo
left a comment
Alexendoo
left a comment
Member
There was a problem hiding this comment.
Hi, thanks for taking this over
Alexendoo
reviewed
Dec 17, 2022
Alexendoo
reviewed
Dec 18, 2022
Alexendoo
left a comment
Alexendoo
left a comment
Member
There was a problem hiding this comment.
Sorry spotted a couple more things, that'll be it this time though I swear 😄
Contributor
|
☔ The latest upstream changes (presumably #10099) made this pull request unmergeable. Please resolve the merge conflicts. |
chansuke
force-pushed
the
issue-9702
branch
2 times, most recently
from
2ac0463 to
6fd0329
Compare
Alexendoo
approved these changes
Dec 20, 2022
Member
|
Great! Thanks again @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Dec 20, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add slight modification on this PR.
changelog: New lint [
permissions_set_readonly_false]#10063