Remove unnecessary res field in for_each_expr visitors#13156
Merged
Conversation
Collaborator
Member
Author
|
Lintcheck seems to agree. Very nice to have for these kinds of refactors |
xFrednet
approved these changes
Jul 25, 2024
Contributor
|
LGTM, nice refactoring!
And yes, it is, it's insane how quickly it has become part of my workflow :3 cc: @blyxyas because of #12829 in case you're interested Roses are red, |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small refactor in the
for_each_expr*visitors. This should not change anything functionally.Instead of storing the final value
Option<B>in the visitor and setting it toSomewhen we get aControlFlow::Break(B)from the closure, we can just directly return it from the visitor itself now that visitors support that.cc #12829 and #12830 (comment)
changelog: none