Prepare clippy_utils README and Cargo.toml for publishing#13693
Merged
blyxyas merged 1 commit intorust-lang:masterfrom Nov 17, 2024
Merged
Prepare clippy_utils README and Cargo.toml for publishing#13693blyxyas merged 1 commit intorust-lang:masterfrom
clippy_utils README and Cargo.toml for publishing#13693blyxyas merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
rustbot
added
the
S-waiting-on-review
blyxyas
reviewed
Nov 15, 2024
Member
blyxyas
left a comment
blyxyas
left a comment
There was a problem hiding this comment.
Being that the first commit has a single file change, I think we can squash these two commits.
BD103
approved these changes
Nov 17, 2024
Contributor
BD103
left a comment
BD103
left a comment
There was a problem hiding this comment.
Thank you for working on this! :D
Comment on lines
+3
to
+13
| <!-- begin autogenerated nightly --> | ||
| ``` | ||
| nightly-2024-11-14 | ||
| ``` | ||
| <!-- end autogenerated nightly --> |
Contributor
There was a problem hiding this comment.
(Nit) This could be moved to be under the "Usage" section, where it is referred to. (As long as the generation script can handle that!)
Member
Author
There was a problem hiding this comment.
I could, I put it here to put it as early as possible in the README.md, so that scrolling isn't necessary to get to the version. I can change this.
flip1995
force-pushed
the
prepare-clippy-utils-publish
branch
from
34220a7 to
aada4c3
Compare
- Add metadata to clippy_utils/Cargo.toml file - Add clippy_utils README.md file
flip1995
force-pushed
the
prepare-clippy-utils-publish
branch
from
aada4c3 to
74b95f2
Compare
Member
Author
|
@blyxyas Rebased on top of master, and squashed the commits. |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
Based on #13693 Adds 2 subcommands to `cargo dev`: - `cargo dev sync update_nightly`: Which updates the nightly versions in `rust-toolchain` and `clippy_utils/README.md` - `cargo dev release bump_version`: Bumps the version in all relevant `Cargo.toml` files Those are pulled out of #12759, which I'll rebase on this. Next step is to update the documentation, which I'll partly pull out of #12762 r? @blyxyas (as you reviewed the first PR in the chain and were assigned to the second one) cc #13556 changelog: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #13691
Adds metadata to the
clippy_utils/Cargo.toml, which is mostly copied from the rootCargo.toml.Adds a
README.mdfile listing the nightly versionclippy_utilscan be used with, mentions that there are no stability guarantees and the license.The next PR will add automation to update the nightly toolchains in those files and the versions in the
Cargo.tomls.cc #13556
changelog: none