rustup https://github.com/rust-lang/rust/pull/60417/#4054
Closed
matthiaskrgr wants to merge 1 commit into
Closed
rustup https://github.com/rust-lang/rust/pull/60417/#4054matthiaskrgr wants to merge 1 commit into
matthiaskrgr wants to merge 1 commit into
Conversation
Member
Author
|
looks spurious |
Member
Author
|
r? @Manishearth |
Member
|
@bors r+ |
Contributor
|
📌 Commit 24e856f has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
May 1, 2019
rustup rust-lang/rust#60417 cc rust-lang/rust#60448 changelog: none
eddyb
reviewed
May 1, 2019
| ExprKind::Use(ref expr) => { | ||
| ExprKind::DropTemps(ref expr) => { | ||
| let expr_pat = self.next("expr"); | ||
| println!("Use(ref {}) = {};", expr_pat, current); |
Contributor
There was a problem hiding this comment.
This is wrong, should say DropTemps.
Member
|
@bors r- |
eddyb
reviewed
May 1, 2019
| let c: fn(_) -> _ = ExprKind::Use; | ||
| ExprKind::DropTemps(ref e) => { | ||
| let c: fn(_) -> _ = ExprKind::DropTemps; | ||
| c.hash(&mut self.s); |
Contributor
There was a problem hiding this comment.
Huh, this should hash mem::discriminant (or thereabouts) like rustc does.
Preexisting though, better not to fix it in this PR.
cc @oli-obk @Manishearth
eddyb
reviewed
May 1, 2019
| }, | ||
| hir::ExprKind::Use(ref e) => { | ||
| hir::ExprKind::DropTemps(ref e) => { | ||
| println!("{}Use", ind); |
Contributor
|
Not sure if this will fail/be stopped, but I left a couple comments with some necessary changes. |
Member
Author
|
oops.. |
Member
|
could have just pushed to this one 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc rust-lang/rust#60448
changelog: none