Skip to content

Implement flat_map lint #4231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 16 commits into from
Aug 14, 2019
Merged

Implement flat_map lint #4231

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
1fd617d
Add test for unnecessary_flat_map
jeremystucki Jun 24, 2019
c7da4c2
Implement flat_map lint
jeremystucki Jun 24, 2019
05d9f88
Merge branch 'origin/master' into flat-map
jeremystucki Aug 11, 2019
f0ce04f
Handle calls with 'std::convert::identity'
jeremystucki Aug 11, 2019
b651f19
Rename 'flat_map' → 'flat_map_identity'
jeremystucki Aug 11, 2019
5fd7d44
Refactor if_chain
jeremystucki Aug 11, 2019
df90630
Update rustdoc
jeremystucki Aug 11, 2019
6ddf8c3
Run 'update_lints'
jeremystucki Aug 12, 2019
09e9568
Change lint type from 'pedantic' → 'complexity'
jeremystucki Aug 12, 2019
3a65e4e
Minor refactoring
jeremystucki Aug 12, 2019
d51136d
Use 'span_lint_and_sugg'
jeremystucki Aug 12, 2019
4275d7b
Run 'update_lints'
jeremystucki Aug 12, 2019
6a263c0
Add 'unnecessary_flat_map.fixed'
jeremystucki Aug 13, 2019
d578c43
Use correct span
jeremystucki Aug 13, 2019
2fe5e2c
Update test
jeremystucki Aug 13, 2019
2bfcf89
Merge branch 'origin/master' into flat-map
jeremystucki Aug 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use correct span
  • Loading branch information
@jeremystucki
jeremystucki committed Aug 13, 2019
commit d578c43c51823952923f0698a3f2283cb3fcca0d
2 changes: 1 addition & 1 deletion clippy_lints/src/methods/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2180,7 +2180,7 @@ fn lint_flat_map_identity<'a, 'tcx>(
span_lint_and_sugg(
cx,
FLAT_MAP_IDENTITY,
*span,
span.with_hi(expr.span.hi()),
message,
"try",
"flatten()".to_string(),
Expand Down