Skip to content

Rustup to https://github.com/rust-lang/rust/pull/64746#4572

Closed
phansch wants to merge 1 commit into
rust-lang:masterfrom
phansch:rustup
Closed

Rustup to https://github.com/rust-lang/rust/pull/64746#4572
phansch wants to merge 1 commit into
rust-lang:masterfrom
phansch:rustup

Conversation

@phansch

@phansch phansch commented Sep 25, 2019

Copy link
Copy Markdown
Contributor

changelog: none

@phansch phansch changed the title Rust up to https://github.com/rust-lang/rust/pull/64746 Rustup to https://github.com/rust-lang/rust/pull/64746 Sep 25, 2019
@flip1995

Copy link
Copy Markdown
Member

@bors r+ p=1

@bors

bors commented Sep 25, 2019

Copy link
Copy Markdown
Contributor

📌 Commit d0b1660 has been approved by flip1995

@bors

bors commented Sep 25, 2019

Copy link
Copy Markdown
Contributor

⌛ Testing commit d0b1660 with merge f59209c...

bors added a commit that referenced this pull request Sep 25, 2019
@bors

bors commented Sep 25, 2019

Copy link
Copy Markdown
Contributor

💔 Test failed - checks-travis

@phansch

phansch commented Sep 25, 2019

Copy link
Copy Markdown
Contributor Author

Looks like we're running into rust-lang/cargo#7427

@Manishearth

Copy link
Copy Markdown
Member

This isn't the correct rustup, we should add a type annotation so that the error isn't hit at all.

We should avoid hitting compiler errors in tests, otherwise they tend to exit before some of their things get tested 😄

@Manishearth

Copy link
Copy Markdown
Member

#4574

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants