Fix some tests#4606
Merged
Merged
Conversation
Centril
approved these changes
Oct 1, 2019
Member
Author
|
@bors r=centril |
Contributor
|
📌 Commit f513aa3 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Oct 1, 2019
Fix some tests Might be breaking the rustup? I can't tell, I can't reproduce errors on CI rust-lang/rust#64963 (comment)
Member
Author
|
Removed tests that only ICEd on rustc CI @bors r=Centril |
Contributor
|
📌 Commit 4318854 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Oct 1, 2019
Fix some tests Might be breaking the rustup? I can't tell, I can't reproduce errors on CI rust-lang/rust#64963 (comment)
Member
Author
Contributor
|
💔 Test failed - checks-travis |
Member
Author
|
@bors r=centril retry |
Contributor
|
💡 This pull request was already approved, no need to approve it again.
|
Contributor
|
📌 Commit 4318854 has been approved by |
bors
added a commit
that referenced
this pull request
Oct 2, 2019
Fix some tests Might be breaking the rustup? I can't tell, I can't reproduce errors on CI changelog: none rust-lang/rust#64963 (comment)
Contributor
Contributor
|
💔 Test failed - checks-travis |
Member
Author
|
Right, Rust is ICEing on our integration tests for non-us reasons. We can disable those two if we really want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might be breaking the rustup? I can't tell, I can't reproduce errors on CI
changelog: none
rust-lang/rust#64963 (comment)