Merged
Conversation
Collaborator
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
the
S-waiting-on-review
jieyouxu
reviewed
Dec 10, 2024
Member
jieyouxu
left a comment
jieyouxu
left a comment
There was a problem hiding this comment.
Thanks! I left some minor wording feedback.
apiraino
force-pushed
the
review-policy-2
branch
2 times, most recently
from
b0f205b to
2070b5b
Compare
apiraino
force-pushed
the
review-policy-2
branch
from
2070b5b to
f9ab3ea
Compare
Contributor
Author
|
@jieyouxu I didn't see any other comment so if you don't have further comments maybe we can merge? 🤷♂️ |
Member
|
Oops yeah sorry, I thought this was merged already |
apiraino
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #553 for a second round of comments/fixes/improvements.
I applied a few minor cosmetic changes and some wording (feel free to improve how it flows)