-
-
Notifications
You must be signed in to change notification settings - Fork 15k
rustdoc could use some LD_LIBRARY_PATH handling cleanup #13983
Copy link
Copy link
Closed as not planned
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Metadata
Metadata
Assignees
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.Relevant to the rustdoc team, which will review and decide on the PR/issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
Spawned off of #13732.
Much like our
run-maketests, rustdoc has a problem where it sometimes wants to be using the host'sLD_LIBRARY_PATHto resolve dynamic library dependencies, and sometimes it wants to be using the target'sLD_LIBRARY_PATH. (This largely comes up e.g. when running the testable code blocks embedded within rustdoc documentation blocks.)This issue is not normally exposed under normal uses of rustdoc because most people run it against a stage2 build or a rust distribution. The problem really only arises when running the documentation against stage1.
For the
run-maketests, PR #13753 is taking the approach of feeding in two distinct environment variables (one for the host and one for the target) and relying on tooling within the makefile select the appropriate option. Presumably some similar approach would work for rustdoc.(But in the short term @pnkfelix is just going to disable the incompatible uses of rustdoc for stage1 and point them at this ticket.)