-
-
Notifications
You must be signed in to change notification settings - Fork 15k
Replace fail invocations with ice_condition.raise in rustc #1928
Copy link
Copy link
Closed
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.P-lowLow priorityLow priority
Metadata
Metadata
Assignees
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.P-lowLow priorityLow priority
Type
Fields
Give feedbackNo fields configured for issues without a type.
We should see if conditions can suit our purposes; we may not be able to get rid of every
fail!invocation thatrustccan reach, but it would not hurt to try.Original title: Replace fail with session.bug in rustc
When possible rustc should be using
session.bugorsession.span_buginstead offailbecause that prints out proper error messages.