-
-
Notifications
You must be signed in to change notification settings - Fork 15k
Unnecessary usage of intrinsics::copysignf32/64 in signum #61638
Copy link
Copy link
Closed
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Metadata
Metadata
Assignees
Labels
C-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Type
Fields
Give feedbackNo fields configured for issues without a type.
In
f32::signumandf64::signumwe useintrinsics::copysignf32andintrinsics::copysignf64. However, these intrinsics are exposed with a stable wrapperf32::copysignandf64::copysign. We should use those instead.rust/src/libstd/f32.rs
Line 191 in d132f54
rust/src/libstd/f64.rs
Line 169 in d132f54