Map EINPROGRESS to io::ErrorKind::WouldBlock

[aviramha]

No description provided.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information.

[thomcc]

Please read the about adding new functionality to the stdlib: https://std-dev-guide.rust-lang.org/feature-lifecycle/summary.html. In particular, this needs an API change proposal, as described here: https://std-dev-guide.rust-lang.org/feature-lifecycle/api-change-proposals.html

However, this seems redundant with ErrorKind::WouldBlock, so you'll need to explain how this is different and worth adding.

[thomcc]

You need an unstable annotation. Something like #[unstable(feature = "io_error_inprogress", issue = "none")]

[thomcc]

@rustbot author

[aviramha]

Please read the about adding new functionality to the stdlib: https://std-dev-guide.rust-lang.org/feature-lifecycle/summary.html. In particular, this needs an API change proposal, as described here: https://std-dev-guide.rust-lang.org/feature-lifecycle/api-change-proposals.html

However, this seems redundant with ErrorKind::WouldBlock, so you'll need to explain how this is different and worth adding.

Thanks for the review, followed your lead and opened an issue - rust-lang/libs-team#92. Let's discuss there?

[rustbot]

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

• Stabilizing library features
• Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
• Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
• Changing public documentation in ways that create new stability guarantees
• Changing observable runtime behavior of library APIs

[aviramha]

@rustbot label -S-waiting-on-author +S-waiting-on-review

[thomcc]

The updated PR looks fine to me, although I'm unsure if this needs API approval. I've nominated it to sort that out.

[joshtriplett]

EINPROGRESS is emphatically not WouldBlock. WouldBlock is EAGAIN, which implies that the operation would have blocked but you asked for non-blocking. Thus, various crates react to WouldBlock the way they would for EAGAIN. Those crates should not react to EINPROGRESS the same way.

[thomcc]

Do you think we should add an io::ErrorKind::InProgress error, as the original suggestion had? (I have no opinion on this error)

[joshtriplett]

Yes, I think we should.

[m-ou-se]

Closing this while we figure out what we want here: rust-lang/libs-team#92 :)