Make miri read_dir test a little more robust#103258
Merged
bors merged 1 commit intorust-lang:masterfrom Oct 20, 2022
Merged
Conversation
Collaborator
|
The Miri subtree was changed cc @rust-lang/miri |
rust-highfive
added
the
S-waiting-on-review
RalfJung
reviewed
Oct 19, 2022
Member
There was a problem hiding this comment.
The "Clean up the files in the directory" block below needs to also delete the directory.
Contributor
Author
There was a problem hiding this comment.
Yup, thanks. The tests are failing to compile with a tokio error locally, so this going to be a little painful, sorry.
Member
There was a problem hiding this comment.
Could you open an issue with the command you are using to run the tests, and the error that shows?
They should work locally, too.
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 19, 2022
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103211 (rustdoc: remove class name `location` from sidebar sibling nav) - rust-lang#103223 (Use already checked RHS ty for LHS deref suggestions) - rust-lang#103237 (Clean up codeblock-tooltip rustdoc-gui test) - rust-lang#103239 (Allow #[unstable] impls for fn() with unstable abi.) - rust-lang#103246 (Mark `rust-analyzer` as a host-only tool) - rust-lang#103257 (rustdoc: move `setting-line` color CSS to settings.css) - rust-lang#103258 (Make miri read_dir test a little more robust) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
Make miri read_dir test a little more robust r? `@RalfJung`
Aaron1011
pushed a commit
to Aaron1011/rust
that referenced
this pull request
Jan 6, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#103211 (rustdoc: remove class name `location` from sidebar sibling nav) - rust-lang#103223 (Use already checked RHS ty for LHS deref suggestions) - rust-lang#103237 (Clean up codeblock-tooltip rustdoc-gui test) - rust-lang#103239 (Allow #[unstable] impls for fn() with unstable abi.) - rust-lang#103246 (Mark `rust-analyzer` as a host-only tool) - rust-lang#103257 (rustdoc: move `setting-line` color CSS to settings.css) - rust-lang#103258 (Make miri read_dir test a little more robust) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @RalfJung