Fix unreachable_pub suggestion for enum with fields

[l4l]

Resolves #103317

[rust-highfive]

r? @wesleywiser

(rust-highfive has picked a reviewer for you, use r? to override)

[wesleywiser]

r? compiler

[nagisa]

Doing a quick first pass, will take a closer look later this week.

Would it make sense to also add a run-rustfix test for this, given that the issue mentions cargo fix doing wrong replacements?

I would even consider adding a test without #[allow(unused)], as AFAICT it doesn’t actually impact the scenario this is testing for (took me a moment to understand this.)

[l4l]

Ooh, there are tests for rustfix, that's really nice, will add one.

I would even consider adding a test without #[allow(unused)]

You mean adding an additional one for run-rustfix, right? There are a lot of warnings for cargo-check (check-pass).

[l4l]

Added .fixed file for the same test and put allow(unused) closer to the enum which seems to be clearer.

[nagisa]

You mean adding an additional one for run-rustfix, right? There are a lot of warnings for cargo-check (check-pass).

Yeah, but upon further review I don’t believe that’s necessary at all.

@bors r+ Thanks!

(Side note: it is quite unfortunate that the lint callback infrastructure requires us to figure if a field belongs to an enum variant after the fact, rather than allowing to just change this entire visitor to skip walking enums in the first place. Welp.)

[bors]

📌 Commit 137271a has been approved by nagisa

It is now in the queue for this repository.