Pass InferCtxt to DropRangeVisitor so we can resolve vars#104753
Merged
bors merged 2 commits intorust-lang:masterfrom Nov 24, 2022
Merged
Pass InferCtxt to DropRangeVisitor so we can resolve vars#104753bors merged 2 commits intorust-lang:masterfrom
InferCtxt to DropRangeVisitor so we can resolve vars#104753bors merged 2 commits intorust-lang:masterfrom
Conversation
Collaborator
|
r? @oli-obk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
compiler-errors
force-pushed
the
drop-tracking-var-ice
branch
from
6c6e99e to
024bb8c
Compare
Contributor
|
@bors r+ |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 24, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#103908 (Suggest `.clone()` or `ref binding` on E0382) - rust-lang#104517 (Throw error on failure in loading llvm-plugin) - rust-lang#104594 (Properly handle `Pin<&mut dyn* Trait>` receiver in codegen) - rust-lang#104742 (Make `deref_into_dyn_supertrait` lint the impl and not the usage) - rust-lang#104753 (Pass `InferCtxt` to `DropRangeVisitor` so we can resolve vars) - rust-lang#104771 (Add regression test for issue rust-lang#99938) - rust-lang#104772 (Small accessibility improvements) - rust-lang#104775 (Use ObligationCtxt::normalize) - rust-lang#104778 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The types that we encounter in the
TypeckResultsthat we pass to theDropRangeVisitorare not yet fully resolved, since that only happens in writeback after type checking is complete.Instead, pass down the whole
InferCtxtso that we can resolve any inference vars that have been constrained since they were written into the results. This is similar to how theMemCategorizationContextin theExprUseVisitoralso needs to pass down both typeck results and the inference context.Fixes an ICE mentioned in this comment: #104382 (comment)