Skip to content

rustdoc: add CSS margin between impl docblock and its items#105676

Merged
bors merged 1 commit into
rust-lang:masterfrom
notriddle:notriddle/impl-docblock
Dec 14, 2022
Merged

rustdoc: add CSS margin between impl docblock and its items#105676
bors merged 1 commit into
rust-lang:masterfrom
notriddle:notriddle/impl-docblock

Conversation

@notriddle

@notriddle notriddle commented Dec 14, 2022

Copy link
Copy Markdown
Contributor

Before

image

After

image

@rustbot

rustbot commented Dec 14, 2022

Copy link
Copy Markdown
Collaborator

Failed to set assignee to CraftSpider: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot

rustbot commented Dec 14, 2022

Copy link
Copy Markdown
Collaborator

r? @CraftSpider

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 14, 2022
@rustbot

rustbot commented Dec 14, 2022

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@GuillaumeGomez

GuillaumeGomez commented Dec 14, 2022

Copy link
Copy Markdown
Member

Thanks for the fix and adding the GUI test!

@bors r+ rollup

@bors

bors commented Dec 14, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 79bb6ec has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 14, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2022
@matthiaskrgr
Rollup merge of rust-lang#105676 - notriddle:notriddle/impl-docblock,…
6866cb7 
… r=GuillaumeGomez

rustdoc: add CSS margin between `impl` docblock and its items

## Before

![image](https://user-images.githubusercontent.com/1593513/207471025-c27c298b-4d48-461b-918b-a965b09db4f1.png)

## After

![image](https://user-images.githubusercontent.com/1593513/207471759-1bbabf71-0932-441c-b044-ad0e392ba552.png)
This was referenced Dec 14, 2022
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 14, 2022
@bors
Auto merge of rust-lang#105690 - matthiaskrgr:rollup-khtq97k, r=matth…
ba64ba8 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#105642 (Minor grammar nit.)
 - rust-lang#105658 (Remove ..X from RELEASES.md)
 - rust-lang#105663 (Adjust log line in `fuchsia-test-runner.py`)
 - rust-lang#105664 (rustdoc: apply `pre-wrap` CSS to code-wrapped links)
 - rust-lang#105665 (rustdoc: simplify popover CSS)
 - rust-lang#105676 (rustdoc: add CSS margin between `impl` docblock and its items)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b6d140e into rust-lang:master Dec 14, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 14, 2022
@notriddle notriddle deleted the notriddle/impl-docblock branch December 14, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.68.0

Development

Successfully merging this pull request may close these issues.

4 participants

@notriddle @rustbot @GuillaumeGomez @bors