Skip to content

Inline CSS background images directly into the CSS#107531

Merged
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:inline-images-in-css
Feb 2, 2023
Merged

Inline CSS background images directly into the CSS#107531
bors merged 1 commit into
rust-lang:masterfrom
GuillaumeGomez:inline-images-in-css

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

A nice advantage of this is that it removes a few entries in the list of static files.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 31, 2023
@rustbot

rustbot commented Jan 31, 2023

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

Comment thread src/librustdoc/html/static/css/rustdoc.css Outdated
@GuillaumeGomez

Copy link
Copy Markdown
Member Author

Updated to keep the svg content as is instead of using base64 and added some backslashes.

Comment thread src/librustdoc/html/static/css/rustdoc.css Outdated
Comment thread src/librustdoc/html/static/css/rustdoc.css Outdated
Comment thread src/librustdoc/html/static/css/rustdoc.css Outdated
@GuillaumeGomez

Copy link
Copy Markdown
Member Author

Updated!

@notriddle

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Feb 1, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 63f82db has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 1, 2023
@bors

bors commented Feb 1, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 63f82db with merge 4a77303648d62e07be6ac2b2ba307cba229c6a34...

@bors

bors commented Feb 1, 2023

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 1, 2023
@compiler-errors

Copy link
Copy Markdown
Contributor

@bors retry CI was broken

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 1, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Feb 2, 2023
…s, r=notriddle

Inline CSS background images directly into the CSS

A nice advantage of this is that it removes a few entries in the list of static files.

r? `@notriddle`
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 2, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#107201 (Remove confusing 'while checking' note from opaque future type mismatches)
 - rust-lang#107312 (Add Style Guide rules for let-else statements)
 - rust-lang#107488 (Fix syntax in `-Zunpretty-expanded` output for derived `PartialEq`.)
 - rust-lang#107531 (Inline CSS background images directly into the CSS)
 - rust-lang#107576 (Add proc-macro boilerplate to crt-static test)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 75ea3a9 into rust-lang:master Feb 2, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 2, 2023
@GuillaumeGomez GuillaumeGomez deleted the inline-images-in-css branch February 2, 2023 12:22
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants