Skip to content

Use SipHash-1-3 instead of SipHash-2-4 for StableHasher #107925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bors merged 10 commits into from
Apr 5, 2023
Merged

Use SipHash-1-3 instead of SipHash-2-4 for StableHasher #107925

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bb0969c
Use SipHash-1-3 instead of SipHash-2-4 for StableHasher
thomcc Feb 11, 2023
9d31462
Fix a couple missed hash constants
thomcc Feb 11, 2023
0db1f54
Bless tests
thomcc Feb 11, 2023
36ca32c
Fix a codegen test with some hard-coded hashes
thomcc Feb 11, 2023
476737e
Fix an assembly test with a hard-coded hash
thomcc Feb 11, 2023
46fad95
Fix a debuginfo test with a hard-coded hash
thomcc Mar 5, 2023
931fd85
Fix codegen tests with hard-coded hashes
lqd Apr 3, 2023
dc04b08
Bless rustdoc test with swapped ids
lqd Apr 3, 2023
4e235a7
Bless rustdoc-ui test with new errors order
lqd Apr 3, 2023
46a3d28
Fix function order in an msvc debuginfo test
lqd Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bless rustdoc test with swapped ids 
The ids for the multiple `Item` associated type elements are swapped
between the first and second impl.
  • Loading branch information
@lqd
lqd committed Apr 5, 2023
commit dc04b085f4cfb565e53af794f862b4d2469e7ac5
4 changes: 2 additions & 2 deletions tests/rustdoc/issue-25001.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,14 +21,14 @@ impl Foo<u32> {
}

impl<T> Bar for Foo<T> {
// @has - '//*[@id="associatedtype.Item"]//h4[@class="code-header"]' 'type Item = T'
// @has - '//*[@id="associatedtype.Item-1"]//h4[@class="code-header"]' 'type Item = T'
type Item=T;

// @has - '//*[@id="method.quux"]//h4[@class="code-header"]' 'fn quux(self)'
fn quux(self) {}
}
impl<'a, T> Bar for &'a Foo<T> {
// @has - '//*[@id="associatedtype.Item-1"]//h4[@class="code-header"]' "type Item = &'a T"
// @has - '//*[@id="associatedtype.Item"]//h4[@class="code-header"]' "type Item = &'a T"
type Item=&'a T;

// @has - '//*[@id="method.quux-1"]//h4[@class="code-header"]' 'fn quux(self)'
Expand Down