Skip to content

Sync codegen defaults with compiler defaults and add a ping message so they stay in sync#108616

Merged
bors merged 1 commit into
rust-lang:masterfrom
jyn514:sync-codegen
Mar 5, 2023
Merged

Sync codegen defaults with compiler defaults and add a ping message so they stay in sync#108616
bors merged 1 commit into
rust-lang:masterfrom
jyn514:sync-codegen

Conversation

@jyn514

@jyn514 jyn514 commented Mar 1, 2023

Copy link
Copy Markdown
Member

Looks like this got missed in #107241.

@rustbot

rustbot commented Mar 1, 2023

Copy link
Copy Markdown
Collaborator

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 1, 2023
@albertlarsan68

albertlarsan68 commented Mar 2, 2023

Copy link
Copy Markdown
Member

Can you change the message to be more precise?
Making the message only appear on compiler.toml modified, that says to sync codegen, and an other one the other way round.

@jyn514

jyn514 commented Mar 5, 2023

Copy link
Copy Markdown
Member Author

Sure thing, done :)

@albertlarsan68

Copy link
Copy Markdown
Member

Thanks for the PR!
@bors r+ rollup

@bors

bors commented Mar 5, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit ba0b7af has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 5, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#106440 (Ignore files in .gitignore in tidy)
 - rust-lang#108613 (Remove `llvm.skip-rebuild` option)
 - rust-lang#108616 (Sync codegen defaults with compiler defaults and add a ping message so they stay in sync)
 - rust-lang#108618 (Rename `src/etc/vscode_settings.json` to `rust_analyzer_settings.json`)
 - rust-lang#108626 (rustdoc-json: switch from HashMap to FxHashMap to fix non-determinism)
 - rust-lang#108744 (Don't ICE when encountering bound var in builtin copy/clone bounds)
 - rust-lang#108749 (Clean up rustdoc-js tester.js file)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c86ea5a into rust-lang:master Mar 5, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants