Run "Auto-hide item contents for large items" setting test in mobile mode as well#110064
Closed
GuillaumeGomez wants to merge 1 commit into
Closed
Run "Auto-hide item contents for large items" setting test in mobile mode as well#110064GuillaumeGomez wants to merge 1 commit into
GuillaumeGomez wants to merge 1 commit into
Conversation
Contributor
|
I guess?
|
Member
Author
On desktop you mean?
Do you have an idea in mind maybe? |
Contributor
Either way, yes. Does the implementation of this feature actually involve the screen size?
A header at the top of the file that lists screen sizes to test in. |
Collaborator
|
☔ The latest upstream changes (presumably #110194) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
Author
|
After thinking about it, I think it's useless since there is no UI difference in here. Closing then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #66181.
It extends the test so it's also run in mobile mode.
r? @notriddle