Skip to content

bolt: remove deprecated option value for split-functions#110403

Merged
bors merged 1 commit into
rust-lang:masterfrom
klensy:bolt-deprecate
Apr 18, 2023
Merged

bolt: remove deprecated option value for split-functions#110403
bors merged 1 commit into
rust-lang:masterfrom
klensy:bolt-deprecate

Conversation

@klensy

@klensy klensy commented Apr 16, 2023

Copy link
Copy Markdown
Contributor

Noticed warning at https://github.com/rust-lang-ci/rust/actions/runs/4711883459/jobs/8356538964#step:26:40828, option value was removed at llvm/llvm-project@96f6ec5.

bolt only running on latest supported llvm (yes?), so it's safe to apply this patch.
cc @Kobzol

@rustbot

rustbot commented Apr 16, 2023

Copy link
Copy Markdown
Collaborator

r? @albertlarsan68

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Apr 16, 2023
@albertlarsan68

Copy link
Copy Markdown
Member

r? @Kobzol

@rustbot

rustbot commented Apr 16, 2023

Copy link
Copy Markdown
Collaborator

Failed to set assignee to Kobzol: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@Kobzol

Kobzol commented Apr 16, 2023

Copy link
Copy Markdown
Member

(I don't have review rights).

Should be fine, let's do a perf test to make sure that perf. didn't regress.

@bors try @perf-timer queue

@bors

bors commented Apr 16, 2023

Copy link
Copy Markdown
Collaborator

⌛ Trying commit e4a9d13 with merge 412a49bef7d568577d0294b36b624cb874947090...

@Kobzol

Kobzol commented Apr 16, 2023

Copy link
Copy Markdown
Member

@rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 16, 2023
@bors

bors commented Apr 16, 2023

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions
Build commit: 412a49bef7d568577d0294b36b624cb874947090 (412a49bef7d568577d0294b36b624cb874947090)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (412a49bef7d568577d0294b36b624cb874947090): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) - - 0

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 16, 2023
@albertlarsan68

Copy link
Copy Markdown
Member

@bors r=albertlarsan68,Kobzol

@bors

bors commented Apr 17, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit e4a9d13 has been approved by albertlarsan68,Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2023
@bors

bors commented Apr 18, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e4a9d13 with merge e279f90...

@bors

bors commented Apr 18, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: albertlarsan68,Kobzol
Pushing e279f90 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 18, 2023
@bors bors merged commit e279f90 into rust-lang:master Apr 18, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 18, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e279f90): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.2% [0.2%, 0.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.7% [-1.7%, -1.7%] 1
Improvements ✅
(secondary)
-1.7% [-1.7%, -1.7%] 1
All ❌✅ (primary) -1.7% [-1.7%, -1.7%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.9% [3.1%, 4.4%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants