Add IoSlice::as_bytes by Lucretiel · Pull Request #111277 · rust-lang/rust

Lucretiel · 2023-05-06T04:50:42Z

This PR proposes to add IoSlice::as_bytes. While IoSlice already has Deref<Target=[u8]>, this uses the lifetime of the IoSlice itself, throwing away the larger 'a lifetime; as_bytes allows for getting the original slice with the original lifetime.

ACP: rust-lang/libs-team#93
Fixes #124659

rustbot · 2023-05-06T04:50:50Z

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-05-06T04:50:53Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

Lucretiel · 2023-05-06T04:54:50Z

My own personal use case for this is an attempt to write my own write_all_vectored. I ran into an issue where, given an &mut [IoSlice<'a>], it's not possible to rewrite those slices in-place as the write proceeds, because slicing an IoSlice borrows it (instead of using the original 'a lifetime), which precludes rewriting it in-place.

Lucretiel · 2023-05-06T05:27:50Z

Looks like the classic sorts of failures where an innate method is added and starts to take precedence over a trait method. Maybe as_inner, instead?

joboet · 2023-05-06T11:29:05Z

How about into_bytes? That fits well with methods like OccupiedEntry::into_mut.

aDotInTheVoid · 2023-05-06T15:02:53Z

@rustbot label +T-libs-api -T-libs

bors · 2023-11-23T02:43:11Z

☔ The latest upstream changes (presumably #118154) made this pull request unmergeable. Please resolve the merge conflicts.

Dylan-DPC · 2024-02-09T15:06:22Z

@Lucretiel if you can address the CI failure and the conflicts, we can put this for review

Lucretiel · 2024-02-14T17:45:16Z

Taking a look now, thanks for your patience!

Lucretiel · 2024-02-14T23:11:33Z

Doctests are failing because of the use of an unstable library feature (the one added in this PR); can someone walk me through how to fix?

aDotInTheVoid · 2024-02-15T12:01:24Z

can someone walk me through how to fix?

Add the #![feature to the doctests. Eg

Mark-Simulacrum · 2024-05-13T14:55:18Z

Can we add the same for IoSliceMut? It looks like it has the same lifetime issue.

Lucretiel · 2024-05-13T17:38:48Z

Can we add the same for IoSliceMut? It looks like it has the same lifetime issue.

I'm actually pretty sure we can't, though I'd be happy to be proven wrong. A function resembling fn as_bytes(&self) -> &'a [u8] would end the self borrow when it returns, which would allow aliasing the mutable region. The best you can do is into_bytes_mut(self) -> &'a mut [u8], which doesn't offer many advantages over just dropping the IoSliceMut.

Lucretiel · 2024-05-13T17:39:21Z

In any case, this is (finally) ready to merge, just needs approval from someone.

tgross35 · 2024-07-17T19:28:07Z

+    ///
+    /// assert_eq!(io_slice.into_bytes(), b"def");
+    /// ```
+    #[unstable(feature = "io_slice_as_bytes", issue = "111277")]


The issue number points to this PR; you should open a tracking issue and link it instead.

Also feature gate io_slice_as_bytes -> io_slice_into_bytes if that is the name.

Edit: io_slice_as_slice with the below.

tgross35 · 2024-07-17T19:32:23Z

The ACP at rust-lang/libs-team#93 covers the change here. Two changes from this PR are that the accepted name was as_slice (though presumably this is up for bikeshedding), and that it can be implemented for IoSliceMut too. Could you make these changes, as well as updating the unstable attribute as mentioned above?

@rustbot author

Dylan-DPC · 2024-09-24T08:36:24Z

@Lucretiel any updates on this? thanks

alex-semenyuk · 2024-11-07T16:38:27Z

@Lucretiel
From wg-triage. Closed this PR due to inactivity. Feel free to reopen or raised new one. Thanks for your efforts.

…again, r=<try> Add as_slice/into_slice for IoSlice/IoSliceMut. ACP: rust-lang/libs-team#93 Based on a623c52 (CC `@mpdn)` and rust-lang#111277 (CC `@Lucretiel).` Closes: rust-lang#124659 Tracking Issue: TODO try-job: test-various try-job: dist-various-1 try-job: dist-various-2 r? `@ghost`

…s-again, r=cuviper Add as_slice/into_slice for IoSlice/IoSliceMut. ACP: rust-lang/libs-team#93 Tracking issue: rust-lang#132818 Based on a623c52 (CC `@mpdn)` and rust-lang#111277 (CC `@Lucretiel).` Closes: rust-lang#124659 Tracking Issue: TODO try-job: test-various try-job: dist-various-1 try-job: dist-various-2 r? libs

Rollup merge of rust-lang#132790 - aDotInTheVoid:ioslice-asslice-rides-again, r=cuviper Add as_slice/into_slice for IoSlice/IoSliceMut. ACP: rust-lang/libs-team#93 Tracking issue: rust-lang#132818 Based on a623c52 (CC `@mpdn)` and rust-lang#111277 (CC `@Lucretiel).` Closes: rust-lang#124659 Tracking Issue: TODO try-job: test-various try-job: dist-various-1 try-job: dist-various-2 r? libs

rustbot assigned m-ou-se May 6, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 6, 2023

This comment has been minimized.

Sign in to view

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 6, 2023

This comment has been minimized.

Sign in to view

srijs mentioned this pull request Jun 11, 2023

add specialized Buf::chunks_vectored for Take tokio-rs/bytes#617

Merged

workingjubilee added the A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` label Jul 30, 2023

Dylan-DPC added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 9, 2024

Lucretiel and others added 6 commits February 14, 2024 13:00

Add IoSlice::as_bytes

f4d6d87

Add const to the sys getters; add issue number to #[unstable]

a36bed9

Rename IoSlice::as_bytes to IoSlice::into_bytes

593289f

Fix broken test, probably

b479bf2

Restore windows as_slice method

f5b65e0

Remove defunct windows file

6d3b2a1

Lucretiel force-pushed the io-slice-as-bytes branch from cf9256f to 6d3b2a1 Compare February 14, 2024 18:05

rustbot added O-solid Operating System: SOLID O-unix Operating system: Unix-like labels Feb 14, 2024

rustbot added O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows labels Feb 14, 2024

This comment has been minimized.

Sign in to view

Add missing borrow

73eb085

This comment has been minimized.

Sign in to view

Add feature attribute to doctest

2c85c36

Dylan-DPC added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 16, 2024

joboet mentioned this pull request May 3, 2024

Add std::io::IoSlice::as_slice method #124680

Closed

nolanderc mentioned this pull request May 3, 2024

IoSlice: the Deref impl is too restrictive on the lifetime of the slice, an alternative is needed. #124659

Closed

saethlin linked an issue May 11, 2024 that may be closed by this pull request

IoSlice: the Deref impl is too restrictive on the lifetime of the slice, an alternative is needed. #124659

Closed

tgross35 reviewed Jul 17, 2024

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2024

alex-semenyuk closed this Nov 7, 2024

aDotInTheVoid mentioned this pull request Nov 8, 2024

Add as_slice/into_slice for IoSlice/IoSliceMut. #132790

Merged

Uh oh!

Conversation

Lucretiel commented May 6, 2023 • edited by tgross35 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 6, 2023

Uh oh!

rustbot commented May 6, 2023

Uh oh!

Lucretiel commented May 6, 2023

Uh oh!

This comment has been minimized.

Lucretiel commented May 6, 2023

Uh oh!

joboet commented May 6, 2023

Uh oh!

aDotInTheVoid commented May 6, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Nov 23, 2023

Uh oh!

Dylan-DPC commented Feb 9, 2024

Uh oh!

Lucretiel commented Feb 14, 2024

Uh oh!

This comment has been minimized.

This comment has been minimized.

Lucretiel commented Feb 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aDotInTheVoid commented Feb 15, 2024

Uh oh!

Mark-Simulacrum commented May 13, 2024

Uh oh!

Lucretiel commented May 13, 2024

Uh oh!

Lucretiel commented May 13, 2024

Uh oh!

tgross35 Jul 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tgross35 commented Jul 17, 2024

Uh oh!

Dylan-DPC commented Sep 24, 2024

Uh oh!

alex-semenyuk commented Nov 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Lucretiel commented May 6, 2023 •

edited by tgross35

Loading

Lucretiel commented Feb 14, 2024 •

edited

Loading

tgross35 Jul 17, 2024 •

edited

Loading