Reuse the MIR validator for MIR inlining

[cjgillot]

Instead of having the inliner home-cook its own validation, we just check that the substituted MIR body passes the regular validation.

The MIR validation is first split in two: control flow validation (MIR syntax and CFG invariants) and type validation (subtyping relationship in assignments and projections). Only the latter can be affected by instantiating type parameters.

[cjgillot]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 2e17ca70bd9fff4d0c55926699090ea08cb01388 with merge e986ec863e45a06422e2c807115069afae8dff08...

[bors]

☀️ Try build successful - checks-actions
Build commit: e986ec863e45a06422e2c807115069afae8dff08 (e986ec863e45a06422e2c807115069afae8dff08)

[rust-timer]

Finished benchmarking commit (e986ec863e45a06422e2c807115069afae8dff08): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	1.5%	[1.5%, 1.5%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.7%	[-5.2%, -4.4%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 647.294s -> 648.277s (0.15%)

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[cjgillot]

r? @compiler-errors
This is a more principled version of #113802

[compiler-errors]

@bors r+ rollup=never

[bors]

📌 Commit b6cd700 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit b6cd700 with merge c399954...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing c399954 to master...

[rust-timer]

Finished benchmarking commit (c399954): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-2.9%, -2.9%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 651.513s -> 651.103s (-0.06%)