Make the deadlock panic clearly refer to a deadlock

[Zoxc]

No description provided.

[rustbot]

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

[mati865]

Suggested change

	if !found_cycle {
	panic!("deadlock detected");
	}
	assert!(found_cycle, "deadlock detected");

[Zoxc]

I went with panic! for the cleaner error message here.

[mati865]

https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=6546fb921d5da013fea2262e8ed17427
Assert seems to give the same message

[Zoxc]

I probably confused it with the assert_eq! variants which does have the assertion failed prefix. I prefer the explicit if as the message doesn't directly describe the assertion condition anyway.

[jackh726]

@bors r+ rollup

[bors]

📌 Commit 68ffa33 has been approved by jackh726

It is now in the queue for this repository.

[bors]

⌛ Testing commit 68ffa33 with merge ffe131f...

[bors]

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing ffe131f to master...

[rust-timer]

Finished benchmarking commit (ffe131f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.9%, 1.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.9%	[1.9%, 1.9%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 629.717s -> 629.667s (-0.01%)
Artifact size: 317.90 MiB -> 317.82 MiB (-0.03%)