Detect ruby-style closure in parser by estebank · Pull Request #116645 · rust-lang/rust

estebank · 2023-10-11T23:22:04Z

When parsing a closure without a body that is surrounded by a block, suggest moving the opening brace after the closure head.

Fix #116608.

rustbot · 2023-10-11T23:22:13Z

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

oli-obk · 2023-10-12T07:50:46Z

tests/ui/or-patterns/or-patterns-syntactic-fail.stderr

+help: you might have meant to open the body of the closure
+   |
+LL |     let _ = |A | { B: E| ();
+   |                  +


This is a false positive

I saw this, but I have no clue how we're meant to even start to try to parse such code in practice 😅

I feel it's fine, it still gives people some sense of what's happening.

Yea... idk. I just feel like the suggestion doesn't help. But maybe it's better than without it?

I can always special case it, but the previous error wasn't much better, tbqh

compiler/rustc_parse/src/parser/expr.rs

When parsing a closure without a body that is surrounded by a block, suggest moving the opening brace after the closure head. Fix rust-lang#116608.

oli-obk · 2023-10-12T22:01:30Z

@bors r+

bors · 2023-10-12T22:01:32Z

📌 Commit 6b2c6c7 has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-10-13T07:28:52Z

⌛ Testing commit 6b2c6c7 with merge b82f450...

Detect ruby-style closure in parser When parsing a closure without a body that is surrounded by a block, suggest moving the opening brace after the closure head. Fix rust-lang#116608.

rust-log-analyzer · 2023-10-13T08:35:49Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors · 2023-10-13T08:36:21Z

💔 Test failed - checks-actions

estebank · 2023-10-13T17:52:45Z

@bors retry

bors · 2023-10-13T19:26:31Z

⌛ Testing commit 6b2c6c7 with merge 09eff44...

bors · 2023-10-13T21:37:43Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 09eff44 to master...

rust-timer · 2023-10-13T22:59:16Z

Finished benchmarking commit (09eff44): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 628.692s -> 627.829s (-0.14%)
Artifact size: 271.29 MiB -> 271.31 MiB (0.01%)

rustbot assigned oli-obk Oct 11, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 11, 2023

estebank mentioned this pull request Oct 11, 2023

Compiler error for if/let chaining when not using it inside a map closure syntax error #116608

Closed

This comment has been minimized.

Sign in to view

oli-obk requested changes Oct 12, 2023

View reviewed changes

Detect ruby-style closure in parser

6b2c6c7

When parsing a closure without a body that is surrounded by a block, suggest moving the opening brace after the closure head. Fix rust-lang#116608.

estebank force-pushed the issue-116608 branch from f79232e to 6b2c6c7 Compare October 12, 2023 21:50

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2023

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 13, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 13, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 13, 2023

bors merged commit 09eff44 into rust-lang:master Oct 13, 2023

rustbot added this to the 1.75.0 milestone Oct 13, 2023

Veykril mentioned this pull request Oct 17, 2023

Pull upstream master 2023 10 17 ferrocene/ferrocene#54

Merged

estebank deleted the issue-116608 branch November 9, 2023 05:13

Uh oh!

Conversation

estebank commented Oct 11, 2023

Uh oh!

rustbot commented Oct 11, 2023

Uh oh!

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

oli-obk commented Oct 12, 2023

Uh oh!

bors commented Oct 12, 2023

Uh oh!

bors commented Oct 13, 2023

Uh oh!

rust-log-analyzer commented Oct 13, 2023

Uh oh!

bors commented Oct 13, 2023

Uh oh!

estebank commented Oct 13, 2023

Uh oh!

bors commented Oct 13, 2023

Uh oh!

bors commented Oct 13, 2023

Uh oh!

rust-timer commented Oct 13, 2023

Overall result: no relevant changes - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants