Don't ICE when encountering unresolved regions in `fully_resolve` by compiler-errors · Pull Request #116663 · rust-lang/rust

compiler-errors · 2023-10-12T13:59:23Z

We can encounter unresolved regions due to unconstrained impl lifetime arguments because collect_return_position_impl_trait_in_trait_tys runs before WF actually checks that the impl is well-formed.

Fixes #116525

rustbot · 2023-10-12T13:59:31Z

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

rustbot · 2023-10-12T13:59:33Z

⚠️ Warning ⚠️

These commits modify submodules.

compiler-errors · 2023-10-12T14:00:49Z

r? lcnr

lcnr

can you instead return a FixupError in case resolving the region ended up resolving to another ReVar?

compiler-errors · 2023-10-13T09:55:41Z

@lcnr: There's not currently a FixupError variant for regions, I think.

It's also like literally never going to be a useful error message, I think.

compiler-errors · 2023-10-17T22:43:56Z

@rustbot ready

lcnr · 2023-10-18T15:34:16Z

@bors r+ rollup

bors · 2023-10-18T15:34:18Z

📌 Commit 97d162a has been approved by lcnr

It is now in the queue for this repository.

…=lcnr Don't ICE when encountering unresolved regions in `fully_resolve` We can encounter unresolved regions due to unconstrained impl lifetime arguments because `collect_return_position_impl_trait_in_trait_tys` runs before WF actually checks that the impl is well-formed. Fixes rust-lang#116525

matthiaskrgr · 2023-10-18T20:29:10Z

tests/ui/async-await/in-trait/unconstrained-impl-region.rs

@@ -0,0 +1,21 @@
+// edition: 2021
+
+#![feature(async_fn_in_trait)]


needs update :D

matthiaskrgr · 2023-10-18T20:29:31Z

@bors r- ^

compiler-errors · 2023-10-18T20:40:04Z

blessed (also removed another stray feature gate in a lint doc)

@bors r=lcnr

bors · 2023-10-18T20:40:06Z

📌 Commit ea73f10 has been approved by lcnr

It is now in the queue for this repository.

Rollup of 7 pull requests Successful merges: - rust-lang#116663 (Don't ICE when encountering unresolved regions in `fully_resolve`) - rust-lang#116761 (Fix podman detection in CI scripts) - rust-lang#116795 (Add `#[track_caller]` to `Option::unwrap_or_else`) - rust-lang#116829 (Make `#[repr(Rust)]` incompatible with other (non-modifier) representation hints like `C` and `simd`) - rust-lang#116883 (Change my name in mailmap) - rust-lang#116908 (Tweak wording of type errors involving type params) - rust-lang#116912 (Some renaming nits for `rustc_type_ir`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#116663 - compiler-errors:resolve-regions, r=lcnr Don't ICE when encountering unresolved regions in `fully_resolve` We can encounter unresolved regions due to unconstrained impl lifetime arguments because `collect_return_position_impl_trait_in_trait_tys` runs before WF actually checks that the impl is well-formed. Fixes rust-lang#116525

rustbot assigned petrochenkov Oct 12, 2023

rust-cloud-vms bot force-pushed the resolve-regions branch from 5f1fd77 to 339912c Compare October 12, 2023 14:00

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 12, 2023

rust-cloud-vms bot force-pushed the resolve-regions branch from 339912c to 97d162a Compare October 12, 2023 14:00

rustbot assigned lcnr and unassigned petrochenkov Oct 12, 2023

lcnr reviewed Oct 13, 2023

View reviewed changes

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 17, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2023

matthiaskrgr mentioned this pull request Oct 18, 2023

Rollup of 5 pull requests #116901

Closed

matthiaskrgr reviewed Oct 18, 2023

View reviewed changes

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 18, 2023

Don't ICE when encountering unresolved regions in fully_resolve

ea73f10

rust-cloud-vms bot force-pushed the resolve-regions branch from 97d162a to ea73f10 Compare October 18, 2023 20:39

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 18, 2023

fmease mentioned this pull request Oct 19, 2023

Rollup of 7 pull requests #116923

Merged

bors merged commit 2dd1c8f into rust-lang:master Oct 19, 2023

rustbot added this to the 1.75.0 milestone Oct 19, 2023

This was referenced Oct 19, 2023

ICE "... is not fully resolved'" with min_specialization and lifetime param #103708

Open

ICE: ['?0, &ReEarlyBound(DefId ... is not fully resolved #116947

Closed

github-actions bot mentioned this pull request Oct 31, 2023

Automated pull from upstream master ferrocene/ferrocene#74

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Don't ICE when encountering unresolved regions in `fully_resolve`#116663

Don't ICE when encountering unresolved regions in `fully_resolve`#116663
bors merged 1 commit intorust-lang:masterfrom
compiler-errors:resolve-regions

compiler-errors commented Oct 12, 2023

Uh oh!

rustbot commented Oct 12, 2023

Uh oh!

rustbot commented Oct 12, 2023

Uh oh!

compiler-errors commented Oct 12, 2023

Uh oh!

lcnr left a comment

Uh oh!

compiler-errors commented Oct 13, 2023 •

edited

Loading

Uh oh!

compiler-errors commented Oct 17, 2023

Uh oh!

lcnr commented Oct 18, 2023

Uh oh!

bors commented Oct 18, 2023

Uh oh!

matthiaskrgr Oct 18, 2023

Uh oh!

matthiaskrgr commented Oct 18, 2023

Uh oh!

compiler-errors commented Oct 18, 2023

Uh oh!

bors commented Oct 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

		@@ -0,0 +1,21 @@
		// edition: 2021

		#![feature(async_fn_in_trait)]

Uh oh!

Conversation

compiler-errors commented Oct 12, 2023

Uh oh!

rustbot commented Oct 12, 2023

Uh oh!

rustbot commented Oct 12, 2023

Uh oh!

compiler-errors commented Oct 12, 2023

Uh oh!

lcnr left a comment

Choose a reason for hiding this comment

Uh oh!

compiler-errors commented Oct 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

compiler-errors commented Oct 17, 2023

Uh oh!

lcnr commented Oct 18, 2023

Uh oh!

bors commented Oct 18, 2023

Uh oh!

matthiaskrgr Oct 18, 2023

Choose a reason for hiding this comment

Uh oh!

matthiaskrgr commented Oct 18, 2023

Uh oh!

compiler-errors commented Oct 18, 2023

Uh oh!

bors commented Oct 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

compiler-errors commented Oct 13, 2023 •

edited

Loading