Generate rlibs by default (instead of dylibs)

[alexcrichton]

Closes #11253

[flaper87]

LGTM

[jhasse]

What about https://github.com/mozilla/rust/blob/master/src/librustc/driver/driver.rs#L726?

Also wouldn't this break rustpkg because of #11500?

[alexcrichton]

Good catch on that extra line! I'm running tests now to see if this breaks rustpkg. If it does, I think I'm going to just hardcode rustpkg to dylibs for now.

[jhasse]

Wouldn't it be better to merge #11500? I know that there's duplicated functionality, but this duplicated functionality is also present now. So #11500 doesn't create any, just fixes one which already is there. I still think this duplicated functionality should be removed - yes. But maybe create a separate issue for that?

Hardcoding dylibs into rustpkg doesn't make sense to me. Why not leave the duplicated functionality for now? ;)

Btw: I already had this implemented (default = rlib) and together with 11500 all tests passed IIRC.

[huonw]

#11500 has landed, is this unblocked?

[alexcrichton]

I believe it is!

[alexcrichton]

ping r?