Skip to content

Error if symlinks are not supported in CI#117248

Merged
bors merged 1 commit into
rust-lang:masterfrom
ChrisDenton:ci-symlink
Dec 1, 2023
Merged

Error if symlinks are not supported in CI#117248
bors merged 1 commit into
rust-lang:masterfrom
ChrisDenton:ci-symlink

Conversation

@ChrisDenton

Copy link
Copy Markdown
Member

In CI we want to run as many tests as possible and be alerted if a test isn't run for any reason.

@rustbot

rustbot commented Oct 26, 2023

Copy link
Copy Markdown
Collaborator

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 26, 2023
@m-ou-se

m-ou-se commented Nov 28, 2023

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Nov 28, 2023

Copy link
Copy Markdown
Collaborator

📌 Commit 8ade047 has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2023
@bors

bors commented Nov 29, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8ade047 with merge 3ecd640...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2023
Error if symlinks are not supported in CI

In CI we want to run as many tests as possible and be alerted if a test isn't run for any reason.
@bors

bors commented Nov 29, 2023

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 29, 2023
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@ChrisDenton

Copy link
Copy Markdown
Member Author
Step 1/10 : FROM ubuntu:22.04
  error parsing HTTP 429 response body: invalid character 'T' looking for beginning of value: "Too Many Requests (HAP429).\n"
  The command has failed after 5 attempts.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2023
@bors

bors commented Nov 29, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8ade047 with merge e05b326...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2023
Error if symlinks are not supported in CI

In CI we want to run as many tests as possible and be alerted if a test isn't run for any reason.
@bors

bors commented Nov 29, 2023

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 29, 2023
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@compiler-errors

Copy link
Copy Markdown
Contributor

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2023
@bors

bors commented Nov 30, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8ade047 with merge 6f4e3cc...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2023
Error if symlinks are not supported in CI

In CI we want to run as many tests as possible and be alerted if a test isn't run for any reason.
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors

bors commented Nov 30, 2023

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 30, 2023
@ChrisDenton

Copy link
Copy Markdown
Member Author

@bors retry let's try this again

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2023
@bors

bors commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8ade047 with merge 9cf18e9...

@bors

bors commented Dec 1, 2023

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: m-ou-se
Pushing 9cf18e9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 1, 2023
@bors bors merged commit 9cf18e9 into rust-lang:master Dec 1, 2023
@rustbot rustbot added this to the 1.76.0 milestone Dec 1, 2023
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (9cf18e9): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.6% [1.6%, 1.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.6% [1.6%, 1.6%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.427s -> 673.541s (0.17%)
Artifact size: 313.37 MiB -> 313.37 MiB (-0.00%)

@ChrisDenton ChrisDenton deleted the ci-symlink branch December 3, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants